kelseyhightower / envconfig

Golang library for managing configuration data from environment variables
MIT License
5.01k stars 377 forks source link

Unnecessary initialization of struct pointers fix #201

Open hexdigest opened 2 years ago

hexdigest commented 2 years ago

Here is the correct version of the removeEmptyStructs mentioned in #113 that support multiple levels of structs nesting when some levels can be pointers and some not:

https://github.com/hexdigest/envconfig/blob/master/envconfig.go#L230:L263

I also added tests for this func. Hope it helps to everyone who struggle from the same issue.

@kelseyhightower not quite sure that point_up thing can be a good candidate for a PR because it's more of a cleanup rather than an actual fix for the env parser even though I don't see how it can break something.