cleanup pass, simplifying field handling funcs

kelseyhightower / envconfig

Golang library for managing configuration data from environment variables

MIT License

5.02k stars 377 forks source link

Closed teepark closed 8 years ago

teepark commented 8 years ago

@kelseyhightower this is the PR to straighten out the call path for parsing/setting fields.

teepark commented 8 years ago

I've squeezed a few other tweaks in here:

de-dent most of Process with a continue if !f.CanSet()
verify that spec is a reflect.Ptr before calling Elem() -- fixes a panic case

Happy to break those out separately if you'd prefer.