envconfig: support pointers

kelseyhightower / envconfig

Golang library for managing configuration data from environment variables

MIT License

5.02k stars 377 forks source link

envconfig: support pointers #44

Closed fsouza closed 8 years ago

fsouza commented 8 years ago

I included three test cases:

a pointer to a string
a pointer to a string with default value
a pointer to a string with no value declared

Please let me know if you want more test cases (involving other pointer types, for example).

I apologize for not discussing the change before sending the PR, please let me know if you think that this is a bad idea, or if you have any other feedback!

fsouza commented 8 years ago

Please hold on, I'm adding new test cases:

ensure that an undefined value gets a nil pointer (no unecessary allocations)
pointers + default values

fsouza commented 8 years ago

This is good for review now, please take a look! :-)

teepark commented 8 years ago

This looks great! Thanks so much.