Use strconv.ParseBool - Githubissues

kelseyhightower / envconfig

Golang library for managing configuration data from environment variables

MIT License

5.02k stars 377 forks source link

Use strconv.ParseBool #76

Closed AlekSi closed 7 years ago

AlekSi commented 7 years ago

I noticed that some code paths use == "true". This means that, for example, True will not work. In the same time, bool's default description is True or False.

It's better to use strconv.ParseBool everywhere.

teepark commented 7 years ago

Yes 100%. I'd merge that PR so fast...