search

kelseyhightower / kubernetes-the-hard-way

Bootstrap Kubernetes the hard way. No scripts.
Apache License 2.0
40.72k stars 13.96k forks source link

Fix encryption-config.yaml is missing issue #780

Open chiukapoor opened 4 months ago

chiukapoor commented 4 months ago

Updates

Issue

mikerybka commented 4 months ago

Right on!

kbenson commented 4 months ago

Just ran into this problem and had to look up an issue to find a solution. If this ensures the file is present, seems like it should be accepted. The directions as written have a breaking bug without this.

chiukapoor commented 4 months ago

@kelseyhightower please review the PR.

DEmmons commented 3 months ago

This is a great help, but there's an issue with this approach - in the course of completing lab 06-data-encryption-keys.md a copy of this file is made in the root of the repo, with the encryption key in it. The .gitignore entry is needed to prevent this from being committed back to the repo when changes are made. a simple solution is to name the missing file 'configs/encryption-config-template.yaml' so .gitignore will not match it, and update the relevant line in 06-data-encryption-keys.md accordingly to reference it.

[edit: never mind, this is already addressed]

chiukapoor commented 3 months ago

This is a great help, but there's an issue with this approach - in the course of completing lab 06-data-encryption-keys.md a copy of this file is made in the root of the repo, with the encryption key in it. The .gitignore entry is needed to prevent this from being committed back to the repo when changes are made. a simple solution is to name the missing file 'configs/encryption-config-template.yaml' so .gitignore will not match it, and update the relevant line in 06-data-encryption-keys.md accordingly to reference it.

The .gitingore file still prevents encryption-config.yaml in the root of the repo from being accidentally committed. I just have added another condition to allow the encryption-config.yaml in the configs folder

richabanker commented 3 months ago

Also ran into this recently, thanks for the PR!

benjaminapetersen commented 2 months ago

Working on this today as well and noticed the missing file. 👍

oates commented 2 months ago

I came looking for a PR on this before doing the work myself. I also ran into the issue and had to do a workaround by manually creating the file. Having the file in the config folder would resolve the issue. Thanks for the PR @chiukapoor