kelseymh / G4CMP

A low energy condensed matter physics package for Geant4
GNU General Public License v3.0
28 stars 18 forks source link

Changed Luke Scattering rate in G4CMPProcessUtils #14

Closed emichaud4 closed 1 year ago

emichaud4 commented 1 year ago

In G4CMPProcessUtils, multiplied line 472 by mach to get the correct Luke scattering rate.

kelseymh commented 1 year ago

Emile, we never merge anything directly onto master/main. We are following the GitFlow workflow model:

  1. Make feature branches from develop (or other feature branches).
  2. Merge feature branches back onto develop, or onto the parent feature branch, and apply a tag with the branch/ticket/issue name.
  3. Merge ONLY develop onto master/main, and apply a semantic versioning release tag.
kelseymh commented 1 year ago

At the top of G4CMPProcessUtils.cc, add a short (one line or 1-1/2 line) comment with a date stamp, in chronological order with the existing comments. Describe what you are changing and why.

emichaud4 commented 1 year ago

At the top of G4CMPProcessUtils.cc, add a short (one line or 1-1/2 line) comment with a date stamp, in chronological order with the existing comments. Describe what you are changing and why.

Also done!

emichaud4 commented 1 year ago

Emile, we never merge anything directly onto master/main. We are following the GitFlow workflow model:

  1. Make feature branches from develop (or other feature branches).
  2. Merge feature branches back onto develop, or onto the parent feature branch, and apply a tag with the branch/ticket/issue name.
  3. Merge ONLY develop onto master/main, and apply a semantic versioning release tag.

Sorry, I though I was asking to merge into develop, I should have double checked, my bad!