search

kelseymh / G4CMP

A low energy condensed matter physics package for Geant4
GNU General Public License v3.0
28 stars 18 forks source link

G4 cmp 362 impact sarkis yields #15

Closed dfsadek closed 1 year ago

dfsadek commented 1 year ago

For debugging and optimizing the implementation of IMPACT@TUNL ionization yield measurement result and the latest Sarkis model for ionization yield in Silicon.

kelseymh commented 1 year ago

General comment: Please update ChangeHistory at the top with today's date, JIRA ticket name and a one-line description.

kelseymh commented 1 year ago

Please do not commit from Jupyter areas. Please remove the entire .ipynbcheckpoints directory.

kelseymh commented 1 year ago

Please make sure that you add all of your new source files to library/CMakeLists.txt.

You can test this by building using CMake.

dfsadek commented 1 year ago

General comment: Please update ChangeHistory at the top with today's date, JIRA ticket name and a one-line description.

Done. Lives locally on my machine till we decide to commit the changes.

dfsadek commented 1 year ago

Please do not commit from Jupyter areas. Please remove the entire .ipynbcheckpoints directory.

I removed the .ipynbcheckpoints and .DS_store from G4CMP-362. I also added them in the .gitignore file just in case any of these files appear one more time. I doubt that could be a .ipynbcheckpoints on the master branch but I didn't want to touch the master. Could you please, double check?

dfsadek commented 1 year ago

Please make sure that you add all of your new source files to library/CMakeLists.txt.

You can test this by building using CMake.

I added my header and source files to library/CMakeLists.txt.