In the energy-momentum calculation, we use a Taylor expansion, and the valley direction is where the energy hits its minima
The further the direction of the momentum from the valley, the bigger the inaccuracy will be
Currently, after the charge changes its direction due to scattering or transportation, the valley is not being changed.
To address this issue, a dynamic valley assignment is needed to ensure the valley the charge is assigned to is the closest valley
To do this, I propose FillParticleChange does not accept a valley input anymore; it calculates the valley from momentum and passes it to the 3-argument version of itself
The only place we use the 3-argument version of FillParticleChange is in LukeScattering, where I made it so that the valley gets calculated from Momentum
In the energy-momentum calculation, we use a Taylor expansion, and the valley direction is where the energy hits its minima The further the direction of the momentum from the valley, the bigger the inaccuracy will be Currently, after the charge changes its direction due to scattering or transportation, the valley is not being changed. To address this issue, a dynamic valley assignment is needed to ensure the valley the charge is assigned to is the closest valley
To do this, I propose FillParticleChange does not accept a valley input anymore; it calculates the valley from momentum and passes it to the 3-argument version of itself The only place we use the 3-argument version of FillParticleChange is in LukeScattering, where I made it so that the valley gets calculated from Momentum