With the addition of new kinematics, the K_Valley and K_HV represent Transport and Quasi Momentum, which causes confusion.
Instead, the best approach is to have a single momentum and a single wave vector definition. The momentum will be transport momentum (which will be used in Geant4 transportation), and the wave vector will be quasi-momentum over hbar, which will be used in scatterings.
This code change fixes both a bug introduced in G4CMP-369 and also removes all instances of K_Valley and K_HV while implementing a single definition for wavevector K with relevant functions to map other values into it and vice versa.
With the addition of new kinematics, the K_Valley and K_HV represent Transport and Quasi Momentum, which causes confusion. Instead, the best approach is to have a single momentum and a single wave vector definition. The momentum will be transport momentum (which will be used in Geant4 transportation), and the wave vector will be quasi-momentum over hbar, which will be used in scatterings.
This code change fixes both a bug introduced in G4CMP-369 and also removes all instances of K_Valley and K_HV while implementing a single definition for wavevector K with relevant functions to map other values into it and vice versa.