search

kelszo / obsidian-file-explorer-plus

A plugin for https://obsidian.md, which enables the ability to hide and pin specific files and folders in the file explorer by applying custom filters.
GNU Affero General Public License v3.0
60 stars 3 forks source link

"Toggle hide filter" command doesn't show entries added by "Quick Action" #3

Open LinkZ-LynX opened 1 year ago

LinkZ-LynX commented 1 year ago

What happened?

The problem: For individual filters, the "Toggle hide filter" command doesn't show entries that were added by "Quick Action" for hiding by right-clicking in the Explorer pane.

image

The reason: Entries added by "Quick Action" don't have a name attribute. After filling in the name value for this path entry the "Toggle hide filter" command correctly shows missing the entry.

image

What did you expect to happen?

The "Toggle hide filter" command should show entries that were added by "Quick Action" for hiding in the Explorer pane. The simplest solution IMHO is to automatically fill the name attribute value with the hiding folder/file name.

Can you reproduce the bug, if so how? As detailed but minimal as possible.

Just use "Quick Action" to hide in the Explorer pane and try to toggle that single hide filter using the command.

Other?

No response

Plugin version

1.1.3

Obsidian version

1.4.16

OS

Windows

kelszo commented 1 year ago

This was sort of intentional, but I will add so that new filters automatically get a “Unnamed filter ” name 👍