search

kelvinfan001 / findalicious

Swipe through restaurants with friends and decide on where to eat! (Formerly Chicken Tinder)
https://findalicious.herokuapp.com
GNU General Public License v3.0
5 stars 1 forks source link

Get Docker and Heroku to accept new directory structure #112

Closed kelvinfan001 closed 3 years ago

kelvinfan001 commented 3 years ago

Please see individual commit messages for additional details.

kelvinfan001 commented 3 years ago

@avatarneil Heroku build was failing because the ESLint version required by react-scripts was v6.x, but your previous PR used react-scripts v7.x. To deal with this, I bumped react-scripts to v4.x. However, in 4.x, https://github.com/facebook/create-react-app/issues/9887 happened. Basically react-scripts now merges our rules in our own eslint configs with the react ones, thus any error rules we specified can now prevent react from compiling. For now, I've removed airbnb-base, as that was the extension that findalicious violated the most and made some minor linting fixes that let react compile for now. With this PR, Heroku should be able to build.

kelvinfan001 commented 3 years ago

With https://github.com/kelvinfan001/findalicious/pull/112/commits/016ca86a879787a2d779f9d071eb26b8147a336d, we no longer need the above workaround.