kelvinhokk / cordova-plugin-localization-strings

Cordova Plugin for Localization of Strings on the App
MIT License
119 stars 106 forks source link

Support localising of config.xml permission strings #3

Closed pke closed 7 years ago

pke commented 7 years ago

NSLocationWhenInUseUsageDescription NSLocationAlwaysUsageDescription NSCameraUsageDescription etc

should also be localised.

So instead of automatic detecting of what needs to go into InfoPlist.strings I'd suggest to have 2 translation files for each language, one for config.json and one for app.json. Everything from config.json goes into InfoPlist.strings.

What do you think?

AndreasGassmann commented 7 years ago

I'm facing the exact same issue.

Another way would be to modify the existing json like that:

{
  "app": {
    "myString": "Translation"
  },
  "config": {
    "NSCameraUsageDescription": "Take pictures"
  }
}

Any thoughts on this?

kelvinhokk commented 7 years ago

I just updated the plugin, would you like to give 0.1.4 a spin?

pke commented 7 years ago

@kelvinhokk thanks for the effort! I'll try it out.

One suggestion though about the version number: with semver that should require a major version bump, what you think? I think it does not make sense to fiddle around with patch versions and not having a major version of at least 1. It makes proper semver very difficult.

kelvinhokk commented 7 years ago

Good point there. i have unpublished 0.1.4 and bumped the version to 1.0.0

pke commented 7 years ago

@kelvinhokk Haven't had time to check it out yet. Will report back here. @AndreasGassmann did you check it?

kelvinhokk commented 7 years ago

I've been using 1.0.1 for my project, and it seems to work ok so far. Closing this issue for now.