Use different key per platform in json file

kelvinhokk / cordova-plugin-localization-strings

Cordova Plugin for Localization of Strings on the App

MIT License

119 stars 106 forks source link

Use different key per platform in json file #38

Closed JanMisker closed 5 years ago

JanMisker commented 5 years ago

A quick fix for my issue #37 was to change the .app key to .app_ios and .app_android. This way the android xml files are not 'contaminated' with the illegal keys often needed by iOS.

rodrigograca31 commented 5 years ago

I'm inclined to not accept this PR... Thoughts? :thinking: :thought_balloon:

pklaes commented 5 years ago

I see the need for this, but as i understand with the proposed solution you would always have to maintain the .app translations twice, both for .app_ios and .app_android. It would be better to have three keys:

.app for translations which a valid for both platforms
.app_ios, .app_android specific for each platform as in this PR.

rodrigograca31 commented 5 years ago

@pklaes exactly. I also saw the need but then we had to maintain two versions.... That's a good solution if someone wants to implement it. :)

pklaes commented 5 years ago

I'll have a look at it ...

pklaes commented 5 years ago

See #46