search

kelvinhokk / cordova-plugin-localization-strings

Cordova Plugin for Localization of Strings on the App
MIT License
119 stars 106 forks source link

Removed q dependency #50

Closed felvct closed 5 years ago

felvct commented 5 years ago

Since cordova 9 dropped q as a dependency, I removed it from the project and refactored the q promises to native promise

rodrigograca31 commented 5 years ago

Thanks for your contribution!

rodrigograca31 commented 5 years ago

Will bump the version one of these days. Let's just see if no one complains about any bug.....

Just because I didnt have time to test it. Only reviewed the code and it looks good.

felvct commented 5 years ago

Yep, no worries.

I did build a project locally and the folder structure was as expected, I did not set up a full remote push test suite though.

Let's see how it goes 🙂

rodrigograca31 commented 5 years ago

Just read the other thread where someone complained about q errors...... maybe I should bump the version already?

felvct commented 5 years ago

If this is a critical issue, you could bump it

Worst case: if something should really mess up, I could take a look on it later today

rodrigograca31 commented 5 years ago

:+1:

rodrigograca31 commented 5 years ago

Version bumped and published to npm!