search

kelvintaywl / terraform-provider-circleci

(Unofficial) Terraform Provider for CircleCI
https://registry.terraform.io/providers/kelvintaywl/circleci/latest
Mozilla Public License 2.0
12 stars 3 forks source link

fix: ensure webhook.events & webhook.signing_secret changes are detected correctly #46

Closed kelvintaywl closed 1 year ago

kelvintaywl commented 1 year ago

Resolves #45

This PR fixes the detection of changes for the circleci_webhook resource. Specifically we modified the following:

attribute remarks
events (breaking) switch attribute from List to Set to ensure ordering does not matter
signing_secret disregard returned value from CircleCI V2 API since it's always returned masked

Also modified the circleci_webhooks data source for events attribute.

Importantly, we also added an additional test to confirm no changes to plan are detected if the circleci_webhook resource definition did not change indeed.