kelvintaywl / terraform-provider-circleci

(Unofficial) Terraform Provider for CircleCI
https://registry.terraform.io/providers/kelvintaywl/circleci/latest
Mozilla Public License 2.0
12 stars 3 forks source link

Fix `circleci_schedule` resource attributes #47

Closed kelvintaywl closed 2 months ago

kelvintaywl commented 1 year ago

Currently, the various attributes for circleci_schedule are defined as Lists:

These should be Set, not List. Fixing this should 1. ensure uniqueness of items out-of-the-box, and 2. ensure ordering does not matter.

(2) would likely fix the detected changes similar to what was found on #45

kelvintaywl commented 1 year ago

tested and noted these lists do not suffer the same issue as webhook per #45.

order is maintained somehow even though we did not sort the list(s) from the API response itself. e.g., https://github.com/kelvintaywl/terraform-provider-circleci/blob/e7d728f56d5af1abbe5fa21e9c09c22fcec1d385/internal/provider/schedule_resource.go#L295-L306

kelvintaywl commented 1 year ago

Marking this as wontfix for now, as it's not urgent.