kelvinyap2014 / yahoo-finance-managed

Automatically exported from code.google.com/p/yahoo-finance-managed
0 stars 0 forks source link

Settings on Download class #44

Closed GoogleCodeExporter closed 8 years ago

GoogleCodeExporter commented 8 years ago
Hi maas, 
the standard behavior was:

'Download Industries
Dim dl As New MarketDownload
Dim respIndustries As IndustryResponse = dl.DownloadIndustries(industries)

where industries is an IEnumerable(Of Industry)

now I've got error stating that no settings was defined.

No problem, I change the previous code in:
'Download Industries
Dim dl As New MarketDownload
Dim dlSet As New MarketDownloadSettings
 dl.Settings = dlSet
Dim respIndustries As IndustryResponse = dl.DownloadIndustries(industries)

My suggestion is, when the setting is nothing, instead throwing an exception, 
you can instantiate a new one.

Regards /// Angel 

Original issue reported on code.google.com by i...@advancedcomputing.ch on 22 Mar 2012 at 10:43

GoogleCodeExporter commented 8 years ago
I want to instantiate every DownloadClient class with a new Settings object, so 
that you can use the overloaded methods without getting an exception per 
default.
Your suggestion wouldn't be possible, because the exception is throwed in 
DownloadClient class, but the Settings are specialized for each class so that 
they must be set in the specialized Download class.

greetz

Maas

Original comment by Maas...@gmail.com on 22 Mar 2012 at 12:44

GoogleCodeExporter commented 8 years ago

Original comment by Maas...@gmail.com on 22 Mar 2012 at 3:06

GoogleCodeExporter commented 8 years ago

I saw that they are specialized. 
Ok, if it is by your design, it's ok for me.

Regards,
Angel

Original comment by i...@advancedcomputing.ch on 22 Mar 2012 at 5:06

GoogleCodeExporter commented 8 years ago
It's just a "beta" version so I didn't checked all the download classes if they 
instantiate a new settings object. In v0.11 it should be.

Maas

Original comment by Maas...@gmail.com on 22 Mar 2012 at 5:47

GoogleCodeExporter commented 8 years ago

Original comment by Maas...@gmail.com on 30 Apr 2012 at 12:48