search

kelyvin / ghost-caffeine-theme

A minimalist, Material Design inspired Ghost Theme for optimal desktop and mobile experiences
https://caffeinecoding.com
MIT License
333 stars 97 forks source link

Pages with Videos are Broken in Mobile View #55

Closed jusuchin85 closed 6 years ago

jusuchin85 commented 6 years ago

Hey @kelyvin ,

Notice this on mobile view when there's a Youtube video attached: image

When viewing the same page on a desktop browser, you can see the heading text after the same Youtube embed: image

I noticed the same is happening on your blog: https://www.caffeinecoding.com/google-io-2016-in-review/

kelyvin commented 6 years ago

@jusuchin85 Thanks for reporting this issue! I will investigate right now and see if I can get a quick patch fix in.

jusuchin85 commented 6 years ago

Great! Thanks, @kelyvin !

kelyvin commented 6 years ago

Hi @jusuchin85, I think I fixed the issue. Can you try pulling the latest release here (https://github.com/kelyvin/caffeine-theme/releases/tag/v3.0.4) and giving it a try?

Youtube seems to be doing some code injection on video embedding, which dynamically tries to style the page. This seems to have caused issues, so I overrode their style changes with my own. Let me know if this fixes your problem! It seems to be fixed with my post (https://www.caffeinecoding.com/google-io-2016-in-review/).

jusuchin85 commented 6 years ago

Thanks, man! I'll give it a try again when I reach home. On the train back now.

jusuchin85 commented 6 years ago

Thanks @kelyvin ! The fix works!