search

kelyvin / ghost-caffeine-theme

A minimalist, Material Design inspired Ghost Theme for optimal desktop and mobile experiences
https://caffeinecoding.com
MIT License
333 stars 97 forks source link

Refactor code to modern standards #62

Open kelyvin opened 6 years ago

kelyvin commented 6 years ago

It's been a long time since the code has been cleaned up. It originally started as a fork of another project but has since deviated drastically. As a result, it's appropriate to make updates to the internals. The refactor the code to leverage the following:

  1. [x] Update gulp builds
  2. [x] Remove bower and switch to npm/yarn full-time
  3. [ ] Update code to ES6 standards
  4. [x] Font awesome 5 upgrade
  5. [ ] Improve JS code with better architecture and ghost v2 compliance
  6. [ ] Replace gulp to webpack for modern client-side bundling

It's difficult trying to find the time to do this myself, so if anyone would like to volunteer, you'd be the real mvp.

nickjamesio commented 6 years ago

Hey @kelyvin,

I would love to help! I literally just got my own ghost blog hosted yesterday and forked the uno-zen theme with the intention to use it. See https://nickjames.io. Last night I stumbled on your theme and will be using yours instead.

I'm still getting the hang of ghost theme development, but I was able to make some enhancements to my fork of uno-zen. I removed bower and moved to npm, upgrade to gulp v4, added ES6 support using Babel, and removed some unnecessary dependencies.

I will fork your theme to use for myself but will be opening some PRs soon to address some of the things outlined. Looking forward to helping out!

kelyvin commented 6 years ago

@nickjamesio You are awesome! Please let me know if you have any questions or need any help along the way as well. Would also like to leverage ES6 modules as well instead of the spaghetti JQuery workarounds, so if you happen to switch to that as well, that would also be sweeeet

nickjamesio commented 6 years ago

Thanks! I am in the process of getting it setup on my local machine now. Had a few quirks to figure out since I am using docker but so far so good. I just successfully built the project using gulp so that is good :) I will definitely reach out if I get stuck or need help!

BaankeyBihari commented 5 years ago

I have sent a pull request for Font Awesome 5. I have tested it locally.