search

kelyvin / ghost-caffeine-theme

A minimalist, Material Design inspired Ghost Theme for optimal desktop and mobile experiences
https://caffeinecoding.com
MIT License
333 stars 97 forks source link

Order main js asset files #68

Closed nickjamesio closed 6 years ago

nickjamesio commented 6 years ago

I accidentally introduced a bug in one of my previous PRs by removing the order of the JS files under main in the gulp file. I was naive to think the order didn't matter, lol. So this PR is just putting back the order.

One issue I observed from the lack of order was when navigating to home page of a blog, it would start out in an opened state. It should have started out with the main cover image displayed.

Lastly, sorry to go mia. I have been plowing through the react and JS courses created by Tyler Mcginnis. I'm almost done done with the last course and should be ready to tackle the webpack stuff here and start using ES6.

kelyvin commented 6 years ago

No problem and thanks for making this change! The es6 + webpack enhancements that you'll be making will hopefully be super helpful when you start full-timing in React as well. Excited to see your future changes!