kelyvin / ghost-caffeine-theme

A minimalist, Material Design inspired Ghost Theme for optimal desktop and mobile experiences
https://caffeinecoding.com
MIT License
333 stars 97 forks source link

revise social links usage. #74

Closed 0t2 closed 5 years ago

0t2 commented 5 years ago

Fixes #15 Facebook and Twitter links now grab from general setting, extra configuration as shown below:

// Code injection - Blog Header
<script>
    var socialConfig = {
        facebook: {
            title: "Caffeine Coding on Facebook"
        },
        twitter: {
            title: "@KelyvinN on Twitter"
        },
        linkedIn: {
            link: "https://linkedin.com/in/kelyvin",
            title: "Kelyvin on LinkedIn"
        },
        github: {
            link: "https://github.com/kelyvin",
            title: "Kelyvin on Github"
        }
    };
</script>
kelyvin commented 5 years ago

HI @0t2,

Sorry for the late reply, was out of town. Thanks for making these changes! Looks great!

I just made one minor comment. Can you also update the readme with the new configuration changes you've implemented? You can update the following section for Social Networks

Thanks!

kelyvin commented 5 years ago

Thanks for submitting this change! Looks great!