search

kemalcr / kemal

Fast, Effective, Simple Web Framework
https://kemalcr.com
MIT License
3.65k stars 189 forks source link

Kemal 1.0.0 is not ready for Crystal 1.0.0 (adopt latest Kilt dependency?) #604

Closed petr-fischer closed 3 years ago

petr-fischer commented 3 years ago

There is Kilt dependency (set to old 0.4.x version) in the Kemal shard.yml, but the Kilt library is not ready for Crystal 1.0.0 - there is no crystal version in their shard.yml.

If there is not "crystal: x.x.x" line in shard.yml, "shards" utility treats it as Crystal requirement < 1.0.0.

Kilt developer was notified here: https://github.com/jeromegn/kilt/issues/26

petr-fischer commented 3 years ago

Kilt 0.6.1 released - why not adopt latest Kilt in the Kemal?

petr-fischer commented 3 years ago

The last problem is crystal-loot/exception_page dependency - still not ready for Crystal 1.0.0.

sdogruyol commented 3 years ago

Yup, maybe I should try updating it :smile:

Ash42Z commented 3 years ago

Looks like execption_page is fixed: https://github.com/crystal-loot/exception_page/pull/21

I'm still having problems because the change is only in master (the version / tag did not change)
I've commented on the issue here: https://github.com/crystal-loot/exception_page/issues/20

sdogruyol commented 3 years ago

exception_page cut a release 👍 All good to go, closing this.