kemalcr / kemal

Fast, Effective, Simple Web Framework
https://kemalcr.com
MIT License
3.62k stars 188 forks source link

MacOs Ci is broken #656

Closed sdogruyol closed 1 year ago

sdogruyol commented 1 year ago

MacOS CI is broken on both latest and nightly on run spec with the following error. //cc @Sija

ld: library not found for -lssl (this usually means you need to install the development package for libssl)
clang: error: linker command failed with exit code 1 (use -v to see invocation)
Error: execution of command failed with code: 1: `cc "${@}" -o /Users/runner/.cache/crystal/crystal-run-spec.tmp  -rdynamic -L/Users/runner/work/_temp/crystal-latest-true-undefined/embedded/lib -lz `command -v pkg-config > /dev/null && pkg-config --libs --silence-errors libssl || printf %s '-lssl -lcrypto'` `command -v pkg-config > /dev/null && pkg-config --libs --silence-errors libcrypto || printf %s '-lcrypto'` -lpcre -lgc -levent -liconv`
Error: Process completed with exit code 1.
Sija commented 1 year ago

Perhaps https://github.com/crystal-lang/crystal/pull/13069 might have sth to do with it?

straight-shoota commented 1 year ago

@Sija That can't be. The failure happens with both nightly and the 1.7.2 release. So it must be inherent to the runner image.

macos-latest was recently upgraded from macos-11 to macos-12, that's a possible cause for the disruption. Best to pin the version explicitly and perform updates intentionally.

However, I presume it's probably the same as https://github.com/actions/runner-images/issues/7128#issuecomment-1434013399 This was just fixed in https://github.com/actions/runner-images/pull/7125. Not sure how long it takes to roll out.

mamantoha commented 1 year ago

This can be fixed by installing pkg-config on macOS runner manually:

- name: Install macOS dependencies
  if: runner.os == 'macOS'
  run: |
    brew install pkg-config

But this is already fixed in the upstream https://github.com/actions/runner-images/pull/7125. So probably just need to wait while this will be released.

sdogruyol commented 1 year ago

Thanks @straight-shoota @Sija @mamantoha 🙏

sdogruyol commented 1 year ago

Fixed now, can be seen in the latest run https://github.com/kemalcr/kemal/actions/runs/4654085351