kemalcr / kemal

Fast, Effective, Simple Web Framework
https://kemalcr.com
MIT License
3.62k stars 188 forks source link

Move to Process.on_interupt #666

Closed grkek closed 10 months ago

grkek commented 1 year ago

I remember this change was implemented before, I see that it is reverted now and I want that change back because developers on Windows are complaining that it broke their builds.

Description of the Change

Switches to a platform agnostic interrupt handler.

Benefits

Windows support

Possible Drawbacks

None

Sija commented 10 months ago

This looks like GTG

straight-shoota commented 10 months ago

Specs are failing though... seems to be only linter issues, but still.

Sija commented 10 months ago

These are resolved by #669