search

kemayo / firefox-sticky-containers

Firefox extention to make the current container "sticky" when opening a new tab
Mozilla Public License 2.0
13 stars 13 forks source link

Can't customise Firefox toolbar when on containerised tab #7

Open cameroncooke opened 6 years ago

cameroncooke commented 6 years ago

If the active tab is in a container when right-clicking the Firefox toolbar and selecting Customise... the toolbar customisation tab does not open and instead you get a blank tab.

If the active tab is a non-containerised tab then it works as expected.

Feels to me that this library should have a blacklist of internal URLs that should always be opened in no container.

mil1i commented 5 years ago

+1, this happens for me as well.

To the point above, I see there already are some blacklisted sites for:

const isPrivilegedURL = function(url) {
  return url == 'about:config' ||
    url == 'about:debugging' ||
    url == 'about:addons' ||
    url.startsWith('chrome:') ||
    url.startsWith('javascript:') ||
    url.startsWith('data:') ||
    url.startsWith('file:') ||
    url.startsWith('about:config');
}

Those have URL addresses though. I wouldn't know what would be used for blacklisting customizing the toolbar.