kemayo / leech

Turn a story on certain websites into an ebook for convenient reading
MIT License
158 stars 24 forks source link

Don't add a space betweenn spans (Royalroad) #92

Closed KeinNiemand closed 1 year ago

KeinNiemand commented 1 year ago

Leech seems to be adding spaces beween span tags which breaks Delve (https://www.royalroad.com/fiction/25225/delve' chapter 164 and probably others) since delve for some reason has the start of a word and the rest of the word in seperate tags. So Rain (MC) sometimes ends up as R ain, and other errors like that.

kemayo commented 1 year ago

Honestly, beautifulsoup doing this in a "prettify" operation is a pretty good argument for just removing all usage of prettify from the code. Such things really shouldn't semantically change the output.

An alternative might be to use something like @annedo's prettierfier. But I think my main reason for prettifying when I added it back-in-the-day was to make debugging easier, so just removing it from the output entirely seems fair to start. 🤔