search

kemayo / obsidian-smart-links

MIT License
26 stars 4 forks source link

Make work in editing mode #1

Open kemayo opened 1 year ago

kemayo commented 1 year ago

Currently this only works in reading mode. It'd be nice if it could also work in editing mode (akin to the built-in auto-linking of URLs).

I think it's possible, by making a view plugin and adding decorations, but am not 100% sure.

berot3 commented 1 year ago

This would be a game-changer for this plugin. I work most of the time in live preview. (I assumed you meant be "editing mode" the live preview and not the Source mode)

danstreeter commented 1 year ago

Agh! Thats why it looks like it didnt work! I'm never ever in 'Reading' mode as live in editing with the live preview thing (so it edits when I cursor over the feature in the note).

A big +1 for me on this one.. my personal workflow / usage of Obsidian makes this AWESOME plugin redundant =(

If I ever get round to learning how to write plugins for Obsidian I'll chip in, but I know nada at the moment I'm afraid.

YousufSSyed commented 1 year ago

@danstreeter How do you make this work in reading mode? Do you type in the phrase to replace then switch to it? I tried that and it doesn't work.

@kemayo Clearly this plugin isn't well documented, and its very unprofessional for the readme to say "I'm so very sorry." for no good reason.

matclab commented 1 year ago

@kemyao, I shall try to compensate the bad vibes send from @YousufSSyed.

Thank you for publishing your work, hoping it will be helpful for others. I (and I assume a lot of other people) appreciate it very much ! And no one with a little bit of empathy would expect that you would provide professional code, readme and support for free.

Thank you again very much !

:heart:

kemayo commented 1 year ago

I mean, I think that telling people that they need to write regular expressions is a legitimate thing to need to apologize for. 😉

That said, I'd agree that the readme could be improved -- it's not entirely clear at the moment that it only works in reading mode. Or, well, it does say that, but I think it's unclear what it really means, since it's an Obsidian feature that's not the most obvious, particularly since 0.13's live preview update made reading mode much less useful. I'm not going to adjust it right now, since @johnbillion's PR looks promising and would remove the need to explain it.

arvinyorro commented 11 months ago

Thanks for all the hard work guys. I came here while searching for a similar feature of GitHub's smart links.

I just started with Obsidian, so live preview is native to my workflow and I thought this wasn't working 😅