search

kemayo / wow-handynotes-battleforazerothtreasures

World of Warcraft addon to tell you where treasures are in Battle for Azeroth (requires HandyNotes)
5 stars 6 forks source link

Filter Mechanized chests based on Normal-vs-Alternate Time #22

Closed jagaudet closed 5 years ago

jagaudet commented 5 years ago

It turns out "Chest 5" spawns in Alternate-Time Mechagon only. Showing that set of chest spawns while in Normal Mechagon is less than useful, and showing the Normal chests while in Alt Mechagon is extremely noisy if you haven't looted any of them. While a little niche, I added a "required_buff" and "required_no_buff" option to the coordinate dictionaries, which allows for filtering based on the "Time Displacement" buff.

My main concern with this merge is that I added a "playerHasBuff" function to config.lua. It (somewhat) duplicates code that exists in handler.lua, but I couldn't access the handler version without making its scope global. As there are no global methods anywhere in the addon, I figured this was the lesser of two evils.

I considered adding a config option to allow people to see unavailable items due to buffs, but I think that's likely to cause users to enable the option due to a lack of understanding of its current scope. That defeats the purpose, so I pulled it out; it was useful for testing, but I can always add it into a local branch for that. If the usage extends past Mechagon island, then it may warrant a revisit.

jagaudet commented 5 years ago

That should be the last of my changes, I updated all of the wowhead-provided coordinates with more refined versions.