search

kemayo / wow-handynotes-battleforazerothtreasures

World of Warcraft addon to tell you where treasures are in Battle for Azeroth (requires HandyNotes)
5 stars 6 forks source link

Rare and treasure fixes #5

Closed NLZ closed 6 years ago

NLZ commented 6 years ago

Adding #1 and kemayo/wow-silverdragon#3, plus a lot of other stuff I found generally in Vol'dun. Added Scavenger of the Sands, not sure if it fits the addon's profile.

kemayo commented 6 years ago

I'll take a bunch of this on faith, I admit!

NLZ commented 6 years ago

A lot of Vol'dun rares had wrong quest id, I guess it was incorrect on wowhead. I see they are no longer listed on the achievement page. Also I got repeating quest ids for junk treasure chests in the same area, and I keep "forgetting" the quests, but I guess thats how they work. But Vol'dun is clearing up nicely.

kemayo commented 6 years ago

Yeah, junk chests are working like the Argus ones did. There's a pool of chests in an area all attached to a questid, so you can loot one from that subzone and then you have to move on for the day.

NLZ commented 6 years ago

By the way I left in a few commented out path() for rares, as the function is not defined there. I leave it up to you if you want to implement it and how. Also how can I get the criterias for an achievement? Asking to fill out Scavenger of the Sands.

kemayo commented 6 years ago

Technically you could fiddle with the API in game -- it's one of the returns from GetAchievementCriteriaInfo(achievementid, i). I just use idTip, though, which adds it to the tooltip in the achievement window.

kemayo commented 6 years ago

Oh, also, path is accessible there via ns.path.

NLZ commented 6 years ago

Thank you. One more if I may, how to find atlas icons? Aside from extracting the game files and browsing until I find something nice.

kemayo commented 6 years ago

I mostly use a combination of browsing AtlasInfo.lua on TownlongYak and my TextureViewer addon.

I've adjusted path in f2d0555 so it can do junk stuff.

NLZ commented 6 years ago

Thanks, you are really resourceful :)