search

kenakamu / UCWA2.0-CS

C# library for UCWA 2.0
MIT License
24 stars 13 forks source link

Bugfix/authentication expiration not handled #39

Closed baywet closed 6 years ago

baywet commented 6 years ago

implemented multiple improvements to the way discovery and authentication as well as authentication exceptions are handled. Cancelling #38 as it includes it as well

baywet commented 6 years ago

fixes #37

baywet commented 6 years ago

thanks for the merge @kenakamu QQ: when do you think you will publish the nuget? is that automated yet?

kenakamu commented 6 years ago

Published. Not automation (yet) but do we want to automate this for every check-in?

Sent from Mailhttps://go.microsoft.com/fwlink/?LinkId=550986 for Windows 10

From: Vincent Biret notifications@github.com Sent: Friday, December 29, 2017 3:41:22 AM To: kenakamu/UCWA2.0-CS Cc: Kenichiro Nakamura; Mention Subject: Re: [kenakamu/UCWA2.0-CS] Bugfix/authentication expiration not handled (#39)

thanks for the merge @kenakamuhttps://github.com/kenakamu QQ: when do you think you will publish the nuget? is that automated yet?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHubhttps://github.com/kenakamu/UCWA2.0-CS/pull/39#issuecomment-354334730, or mute the threadhttps://github.com/notifications/unsubscribe-auth/AJeuvKsCF37njiMjzC3wOlN7bYlMAvOWks5tE-DSgaJpZM4RLZiB.

baywet commented 6 years ago

thanks! every pull request (or PR update) would trigger build + unit tests. every merge to master would trigger build + unit test + release. however I think we should have like a pre-approval on the release definition (to speak in VSTS terms) to allow you to approve or not something getting to nuget. What do you think?

kenakamu commented 6 years ago

Sounds great but we don't have unit test ?

baywet commented 6 years ago

I know but we could set up the infrastructure for it, have a few basic unit tests and build up from there. I'm going to move those discussions to separate threads: