kenakamu / UCWA2.0-CS

C# library for UCWA 2.0
MIT License
24 stars 13 forks source link

cancellation token support and http time out retry policy #48

Closed baywet closed 6 years ago

baywet commented 6 years ago

Hi @kenakamu , @2toLeadMike and myself put together this pull request. it's rather big even if a big part of the changes are only exposing new methods and relaying the cancellation token. That PR brings two major improvements:

I understand it's a rather big PR, and we'd need this PR to be reviewed, merged and the nuget to be published fairly quickly if possible. We're approaching production deployment for one of our major projects. Thanks! And let me know if you have any question. :)

kenakamu commented 6 years ago

As this includes so many fixes which is nothing to do with cancel token, i prefer to have separate PR. However, as this is kind small repo anyway, i do review them all and accept as soon as possible.

kenakamu commented 6 years ago

@baywet Do you need to make method with cancellation token to public when we redirect call from original one? If we have plan to call it directly from outside, it makes sense.

baywet commented 6 years ago

Yeah the idea is to provide the ability to people to provide their cancellation token. Let's say I'm building a web API and the http call gets cancelled. It should be able to pass the cancellation all the way down to stop all the sub http calls the API was making to get the data.

kenakamu commented 6 years ago

merged