search

kenakamu / UCWA2.0-CS

C# library for UCWA 2.0
MIT License
24 stars 13 forks source link

No way to run interactions between two skype users on the same machine? #55

Open sergsalo opened 6 years ago

sergsalo commented 6 years ago

because of the use of static HttpService, it seems there is no way to run two users interaction in the same application. Am I right?

baywet commented 6 years ago

@sergsalo sorry for the late reply. Yes you're right because of this line (and others) https://github.com/kenakamu/UCWA2.0-CS/blob/317476aceb19f5174b08c121684754e6dba91bb2/UCWASDK/UCWASDK/Services/HttpService.cs#L24 today it's impossible to have two different identities in the same process. The HttpClient have a static reference to avoid network port exhaustion, a common issue in .NET. The proper fix would probably to abstract a httpClient Factory/pool, implement a default one and allow people to override it. Feel free to issue a pull request if you want to address the issue