search

kenakamu / UCWA2.0-CS

C# library for UCWA 2.0
MIT License
24 stars 13 forks source link

Default value for AccessLevel #56

Closed mchip88 closed 5 years ago

mchip88 commented 6 years ago

When creating an online meeting, if no accesslevel is sent then the value is set to SameEnterprise. Since the code ignores default values when using post or put requests, the code can't create meetings with access level "Everyone"

mchip88 commented 6 years ago

@kenakamu would you be able to review the change please?

mchip88 commented 5 years ago

Found a typo when building the code, also fixed that

mchip88 commented 5 years ago

sorry @kenakamu , any updates planned?

baywet commented 5 years ago

Hi @mchip88 Thanks for the contribution, your PR is actually tackling two issues: a typo in the sample UWP project, and a serialization issue. The typo issue is simple and can be merged fairly quickly, the serialization one is a bigger concern as it may impact things. Can you split your PR in 2 please? (maybe cherry-pick the typo commit on a different branch and then revert it on this one) so we can have targeted discussions. Thanks!

mchip88 commented 5 years ago

sure @baywet. I've removed the typo issue for the time being. will create different PR for that afterwards

baywet commented 5 years ago

Thanks! @kenakamu this will have an impact on two things as far as I can see: -payloads might get bigger as the library will systematically send default values -we might see behaviors change where the library default values and the API default values are not aligned What do you think?