search

kenan238 / reblessed

A high-level terminal interface library for node.js.
MIT License
87 stars 10 forks source link

Are PRs for updating to modern ECMAScript welcome? #11

Closed rdeforest closed 1 year ago

rdeforest commented 2 years ago

I almost did a spit-take when I saw lib/program.js. I know some projects don't like code cleanup PRs so I thought I'd ping you before putting any work into it. :) If you are interested, I would also include Babel automation to avoid breaking projects which rely on reblessed not using modern ES features.

Additionally, I'm a big fan of CoffeeScript and would be even happier to send you a PR (or set of PRs if you'd like the changes broken into logical chunks) translating the project into CS (while still producing modern and old ES for those who require it).

I totally understand if this kind of thing isn't a priority of the project.

Thanks for raising blessed from the dead!

kenan238 commented 1 year ago

Yes they are! But no useless updates such as updating a var to let, thanks!

kenan238 commented 1 year ago

If you would like a CoffeeScript version, please make sure to create a separate directory for that. I'm keeping reblessed JavaScript only but a CoffeeScript side-port would be great

kenan238 commented 1 year ago

Update: I am already starting the refactoring on another branch

rdeforest commented 1 year ago

Thanks for the update! I'm deep in another project now, so I won't start anything until after your next major release.