codepathreview
commented
10 years ago :+1: Great work overall Kenan! A few notes after checking out the code:
- Good job polishing your UI to make it more twitter branded
- Good job formatting the relative time stamp (Consider externalizing the logic into Util class)
- Great job implementing the compose tweet feature as a dialog
- Nice touch adding the TextWatcher for counting characters
- Great job getting the images displayed in the tweet
- Good job using the ProgressDialog indicating network requests
- Consider using Parcelable or Serializable (benefits) for model objects
- Consider adding null checks in JSON parsing for robust error handling
- Consider using the ViewHolder pattern for your adapters.
Here's a detailed Project 3 Feedback Guide here which covers the most common issues with this submitted project. Read through the feedback guide point-by-point to determine how you could improve your submission.
Let us know if you have any other thoughts or questions about this assignment. Hopefully by now you feel pretty comfortable with all the major pieces to basic Android apps (Views, Controllers, ActionBar, Navigation, Models, Authentication, API Communication, Persistence, et al) and see how they all fit together. We are close now to a turning point in the course where you should be hitting a "critical mass" towards your knowledge of Android.
My app is complete, please review. //cc @thecodepath @nesquena