search

kenany / glicko2-lite

Lightweight Glicko-2 implementation.
MIT License
18 stars 5 forks source link

Return type naming convention #5

Closed ddugovic closed 8 years ago

ddugovic commented 8 years ago

I'm developing a chess server; however, my player.rating object has attributes (r, rd, vol) rather than (rating, rd, vol). It would reduce potential ambiguity if this library followed Glickman's naming convention by returning r rather than rating.

Every player in the Glicko-2 system has a rating r, a rating deviation RD, and a rating volatility σ.

kenany commented 8 years ago

I guess I intended the current name to reduce ambiguity by not shortening it to a single letter. I take it that for your case it would be non-trivial to simply rename the returned attribute to r? Nevertheless I think I'm open to this change if it is desired; no harm done so long as I bump the major version.

btw, love your work on adding variants to stockfish :)

ddugovic commented 8 years ago

Ah, you are correct, I figured out how in JavaScript to map the returned attributes.

And thanks, I'm glad others have helped me with that effort.