Superfluous/Misleading generic parameter in `ExecuteKernel::set_arg_local_buffer`

kenba / opencl3

A Rust implementation of the Khronos OpenCL 3.0 API.

Apache License 2.0

102 stars 13 forks source link

Superfluous/Misleading generic parameter in `ExecuteKernel::set_arg_local_buffer` #35

Closed KarelPeeters closed 3 years ago

KarelPeeters commented 3 years ago

Currently ExecuteKernel::set_arg_local_buffer has a generic type parameter T. Even though it's never actually used. Initially I thought this meant the size was the length of the buffer (with the given data type), but it's indeed the size in bytes.

I think this generic parameter can just be removed.

https://github.com/kenba/opencl3/blob/f8f972e9a65899656e6cd03669f039b8f74976e0/src/kernel.rs#L368-L389

kenba commented 3 years ago

Agreed, generic type parameter removed on develop branch.

KarelPeeters commented 3 years ago

Great, thanks!