search

kenchris / lit-element

A base class for creating web components using lit-html
BSD 3-Clause "New" or "Revised" License
81 stars 10 forks source link

making TS happen #6

Closed filipbech closed 7 years ago

filipbech commented 7 years ago

I changed the outDir so the build-files are in the dist-folder and created a index.js in the root that re-exports everything from the dist-file...

Then I added some any-definitions to shut the ts-compiler up - we could look into what the correct types should be, but I'm not exactly sure for some of these cases.

Then I added a comment with an idea, and one with what I think is a bug, but lets talk about them another time.

kenchris commented 7 years ago

OK, I redid your patch and pushed, and I believe that I incorporated all the correct changes.

Could you check to see if I have done it correctly, or if not, rebase this patch?

filipbech commented 7 years ago

I believe what we need to change the import path to the lit-html, so it doesn't assume a local node_modules folder... so instead of '../node_modules/lit-html' I guess it should be ../../lit-html ?

filipbech commented 7 years ago

Lets just close this PR