search

kenchris / urlpattern-polyfill

URLPattern polyfill
https://www.npmjs.com/package/urlpattern-polyfill
MIT License
268 stars 31 forks source link

Fix canonical pattern string generation. (#53) #59

Closed wanderview closed 2 years ago

wanderview commented 2 years ago

This commit fixes all of the issues described in:

https://github.com/WICG/urlpattern/issues/145

It corresponds to the following implementation CLs:

https://chromium-review.googlesource.com/c/chromium/src/+/3313642 https://chromium-review.googlesource.com/c/chromium/src/+/3315419 https://chromium-review.googlesource.com/c/chromium/src/+/3318605 https://chromium-review.googlesource.com/c/chromium/src/+/3321520 https://chromium-review.googlesource.com/c/chromium/src/+/3328146 https://chromium-review.googlesource.com/c/chromium/src/+/3378528

This commit also includes a fix to path-to-regexp capture in this upstream branch commit:

https://github.com/wanderview/path-to-regexp/commit/d1d81d9910d84d9b10b44ba37a6e231f68f4fee7

wanderview commented 2 years ago

@kenchris PTAL. Sorry for the size of this, but I decided to do a combined pull request instead of separate chained PRs. This brings the polyfill up to parity with the upstream WPT tests.

kenchris commented 2 years ago

Let me publish a new release tomorrow

wanderview commented 2 years ago

Yea, sorry I didn't mention I had more coming before the release you just did.

Next I'm going to start upstreaming my changes to path-to-regexp. Hopefully we can eventually move to a dependency there instead of locally modified file.