Add ponyfill export - Githubissues

kenchris / urlpattern-polyfill

URLPattern polyfill

https://www.npmjs.com/package/urlpattern-polyfill

MIT License

268 stars 31 forks source link

Add ponyfill export #92

Closed Schniz closed 2 years ago

Schniz commented 2 years ago

This PR introduces a new exported path: import 'urlpattern-polyfill/pony' that will not pollute the global scope and will always provide the polyfill implementation.

Notes:

Importing urlpattern-polyfill will pollute the global scope both in runtime and in TypeScript
Importing urlpattern-polyfill/pony will not pollute the global scope at all

This supersedes #91

Schniz commented 2 years ago

Not sure about the name though, would be best if we had urlpattern/ponyfill and urlpattern/polyfill 😅

kenchris commented 2 years ago

Yeah, I am not a fan of the pony name :) Wouldn't it be nicer we we could just import from "urlpattern-polyfill/urlpattern" as that is the name of the object

Schniz commented 2 years ago

oh I named it url-pattern 🤦 fixing

kenchris commented 2 years ago

Generally this looks fine to me, but I would like Sander to have a look as well

SanderElias commented 2 years ago

I do like it!