search

kencrocken / FiraCodeiScript

Mashup Font of FiraCode and Script12
1.38k stars 182 forks source link

Update new Fira Code version #8

Open annguyen115 opened 6 years ago

annguyen115 commented 6 years ago

Hello, I love your library but it not support '>=' and '<=' :(

AllanLRH commented 6 years ago

Works fine here... does the other ligatures work?

screen shot 2018-07-16 at 19 10 24
techieshark commented 5 years ago

In Atom, => (equals followed by greater-than) wasn't showing the ligature that looks like a right double arrow (unicode: ⟹). In VSCode it seems to work.

image

You can see that the ligature is shown correctly in the editor search bar (beneath 'Find in current buffer'), but not the editor's text area (line 36) -- despite other ligatures such as >= working (line 37).

I've tried switching from Language "Auto" (Flow JavaScript) to "Babel" and these are the CSS classes applied to the "=>" element:

syntax--storage syntax--type syntax--function syntax--arrow syntax--js

... and after a bit more digging, it seems syntax--storage syntax--type has font-style: italic, but the => ligature is defined in Regular, not Italic:

image

... so I fixed this via updating Atom > Stylesheet...

.syntax--storage.syntax--arrow { 
  // => ligature is defined in Fira (regular), not iScript (italic)
  font-style: normal;
}

(But also it turned out it was the Dracula theme which had set font-style to italic, so folks using default theme shouldn't have this issue. Just adding this comment should anyone later have a similar issue and need to resolve it.)