search

kendallb / PrintHtml

Open source command line program to print HTML pages using QtWebKit
MIT License
47 stars 18 forks source link

Add optional -json for STDOUT JSON string #7

Open Nineapsofttech opened 6 years ago

Nineapsofttech commented 6 years ago

Add optional -json for STDOUT JSON string. STDOUT Object of

kendallb commented 6 years ago

I like this change, but please move QString dataPath = QApplication::applicationDirPath() back to it's original location below it's comment (much better to define stuff where it is needed, with related comments).

Also please fix all the formatting where the formatting has been compressed as that is now how the code is formatted in this project. So this:

if(this->json){

needs to be come this:

if (this->json) {

Quite a lot of code got reformatted so that all needs to be cleaned up.

kendallb commented 4 years ago

This code tree no longer merges clean, due to other changes in master. Can you resolve the conflicts so I can bring it in?

Also last time we tried Qt5 we ended up with problems (don't recall exactly what they were), but we went back to Qt 4.8 to resolve that. Is Qt5 working OK for you?

kendallb commented 4 years ago

I still have conflicts and can't merge this in clean. Can you resolve them in this PR?