Open kendallroth opened 3 months ago
Persisting panel visibility/position within individual save files is likely unnecessary, as players probably wouldn't have different visibility/position per save. Per-save data may be more useful for configuring which stats are available, but even that could be done as global settings or a ModsData
file (both might make more sense) 🤷.
FWIW, I'd actually prefer the position and stat selection to persist globally, so I do not have to set (or update) them for every city.
Yeah, I'm honestly not sure which approach to take...which is why I've kinda put this on the back-burner for the time being... I do agree there is probably more value in persisting the setting globally than per-save, as I doubt that would really ever occur.
Well, not that you're asking me 🙂, but (again, FWIW), perhaps implement the global method first. That sounds like the easiest. Then, if you feel like it or people beg for a per-city setting, you can add the ability to override the global setting for a given city.
(I assure you, it's purely a coincidence that I prefer the global method.)
Yeah, I could definitely see storing the panel position globally (via settings or ModsData/
), and this would probably be what I try before per-save (at this point).
I'm not entirely certain about storing the panel visibility globally, as there is already the setting to open upon load or not, which seems sufficient... I think the next related change I would make would be to remove that setting in favour of storing the panel visibility per-save 🤷.
However, I'm probably not planning to store the stat selection globally (missed this in first request), as that is persisted within each save, and may change over the lifetime of the save as city services become available or concerns change, etc 🤷.
Inspired by #2, the panel visibility and position should be persisted within a save game. This will require storing the values in a serializable entity (or component?) in ECS, that could then be automatically persisted to the game save. However, this depends on whether there is actually value to this, as compared to other options...
ModSettings/
System docs