kendo-labs / kendo-bootstrapper

GNU General Public License v3.0
49 stars 20 forks source link

Allow the user to specify the order of CSS and JS includes when setting dependencies on an HTML file #13

Closed bsatrom closed 11 years ago

bsatrom commented 11 years ago

Often, a developer will need dependencies included in a very specific way, and it looks like the bootstrapper doesn't allow me to specify the include order on dependencies in an HTML5. Can we add that capability?

mishoo commented 11 years ago

I added support for reordering dependencies. Just select the file and press the UP/DOWN arrow keys, or the "Up" / "Down" buttons.

But just to explain why this wasn't really necessary. In dependency management systems, the ordering is inherently defined by the dependencies. For example, you have 3 files:

Of course, in index.html you need to load foo.js and bar.js, so one way to do that is to specify that index.html depends on foo.js and bar.js. But in this case, the ordering would be not deterministic. If you need to load them in this particular order, it means that bar.js depends on something defined in foo.js — therefore the proper dependency list for this project would be:

and the bootstrapper would list them in the appropriate order.

However, I agree it could be more intuitive for certain users to list all deps on the index.html, therefore there is now support for reordering them.

Also see issue #8 — Derick suggested that we should always load CSS before JavaScript, therefore there is a strict rule about that (so even if you order deps so that JS comes first, they won't come out that way). Should I undo what I did for issue #8?

bsatrom commented 11 years ago

@mishoo that makes sense, but I was having an issue with this last friday during testing. Could have been I was doing it wrong, but ordering should prevent others from being similarly confused.

As for #8, no, there's no need to undo that.