kendo-labs / kendo-bootstrapper

GNU General Public License v3.0
49 stars 20 forks source link

Editing files directly from Bootstrapper #26

Closed toddanglin closed 11 years ago

toddanglin commented 11 years ago

I've configured the Bootstrapper to use Sublime Text 2 via the options dialog.

When click on the "Edit" button next to a file in the Bootstrapper, Sublime Text 2 opens.

But instead of seeing the contents of the target file, I instead see a blank window. No JavaScript console errors. No terminal errors. Tested with TextEdit and experienced similar results.

I assume I'm either A) not pointing at the right executable, or B) that this is some kind of permissions/path problem preventing Bootstrapper from piping the file contents to my editor.

Thoughts?

Sincerely, Mac Mort

mishoo commented 11 years ago

Probably there's a misconfiguration of the editor arguments. For ST2 the arguments should be:

They can be configured in the Settings dialog:

settings

It's a bit strange that the Bootstrapper should have figured them out itself, but if it didn't find the ST2 binary in a standard location then yes, it's possible that the arguments must be configured manually.

Please reopen if the problem persists.

toddanglin commented 11 years ago

That was indeed the issue. Once I added those configurations, everything worked.

Unfortunately, I don't think an "average" user will have any idea how to configure these boxes for their code editor. Hopefully we can make the Bootstrapper really good at "guessing" default configurations and only require user intervention for the edge cases.

In fact, I think these config options should probably be "hidden" by default. As-is, they feel more like a twisted brain teaser or puzzle than a config option most users will want to see. :)

bsatrom commented 11 years ago

Makes sense, and I agree that we should probably remove these options by default.

@mishoo, I know we've talked about making the new project templates pluggable, and I wonder if we should do the same for editor configs, even if its a simple JSON map of editors and location and command defaults that we could easily maintain to add additional default/supported editors