search

kendo-labs / kendo-bootstrapper

GNU General Public License v3.0
49 stars 20 forks source link

Once you import a project from disk, you aren't asked about include filtering again #27

Open burkeholland opened 11 years ago

burkeholland commented 11 years ago

I opened the bootstrapper on a pretty large ASP.NET MVC Project. I should have filtered out everything but my app files, but I didn't The sheer amount of files was just too much for the Bootstrapper to keep up with. Once I was able to remove the project, when I went to add it back, I couldn't specify a filter for those files anymore.

mishoo commented 11 years ago

It should not fail, but I can see that happening (I haven't deal with the infamous EMFILE error in all places.. and import is one of them). I'll work on that.

Just curious, how many files does the project have?

mishoo commented 11 years ago

Seems the issue is more profound than I thought. There are two sides of it. The server imports the project pretty fast, but once imported it will watch the project directory for file changes; for a lot of files this is pretty slow and results in tons of CPU usage (uses Chokidar, which I'll probably replace at some point).

On the other hand, the client-side renders that view with all the files. I tried it for something like 12K files and it's very slow, takes like 30 seconds to render the view (and rendering happens every time the Chrome window gets focus). The app looks frozen during this time.

I'm not sure what's the right way to deal with this. Should we impose a hard limit on number of managed files in the project? I think 1-2K files would work reasonably well and should be enough for any project. The alternative would be to completely rewrite that view and use i.e. a paginated grid, which seems quite a bit of hassle.