kendraio / kendra_home

Kendra Home
https://www.kendra.io
GNU General Public License v2.0
2 stars 2 forks source link

Quick fix to theme/CSS... #42

Closed dahacouk closed 9 years ago

dahacouk commented 9 years ago

So... I know it's all my fault. I've learnt another big lesson: don't do any styling until the basic functionality is there. And also make sure any styling is done site wide so that we don't end up in the situation we are in now where some pages are full width and some pages are not.

The main problem starts at https://www.kendra.io/user (as a non-admin user) the 4 tabs at the top go to pages where the tabs disappear. We need to correct this now because I want to start importing people now.

I need a quick fix.

dahacouk commented 9 years ago

@BBGuy perhaps linked to this issue could be a problem when I save my profile or account (as a non-admin user) the "The changes have been saved" is not viewable.

I'm wondering if we should change the themes (public and admin) to be the same so this is easier to debug. Eat our own dog food?

dahacouk commented 9 years ago

Also add in all these pages we need to fix quickly:

iAugur commented 9 years ago

I have updated the layout on all of these pages. I think we should also:

iAugur commented 9 years ago

I will add the default page elements (tabs, messages) to the page template and remove them from the panel-pages. Then we will have a theme that works both for admin and public.

dahacouk commented 9 years ago

If you can get edit tabs on the pages such as https://www.kendra.io/kendra-hub/partners then that would be great tooooooo! ;-)

iAugur commented 9 years ago

Done!

iAugur commented 9 years ago

I have updated the theme to show default system elements on all pages. Updated all page manager (panels) pages to reflect this (e.g. not double up tabs, message etc) This now allows us to use the same theme for the admin as the public site

iAugur commented 9 years ago

If you are happy with this - can you close the issue

dahacouk commented 9 years ago

Looks good to me thanks!