search

kendryte / k230_sdk

Kendryte K230 SDK
BSD 2-Clause "Simplified" License
172 stars 39 forks source link

[other]: confusing logic in Dockerfile #15

Closed yf13 closed 1 year ago

yf13 commented 1 year ago

Other

The recent Dockerfile adds a FLAG file which is set to "True" when download from ai.b-bug.org fails. The flag is then referenced multiple times later.

When building the docker image from China, the flag is True as the download fails always. However, this will further block using pip mirrors at line #51, this is bad as we need the mirrors.

Is the flag to depict Canaan intranet environment? if so then the logic at line#51 should be reviewed.

wuwentao commented 1 year ago

yes, you are right, we forgot to remove it, thank you very much for your comment. we will enable this pip mirror config in our local dev git repo and publish to github in next release.

you can just edit this file at line #51 and set False to True to quickly fix it .

in addition, we also use github action to release this docker image in ghcr.io/kendryte/k230_sdk https://github.com/kendryte/k230_sdk/pkgs/container/k230_sdk

yf13 commented 11 months ago

@wuwentao this issue seems still exist in latest Dockerfile, at least with v1.1.

wuwentao commented 11 months ago

I'm sorry for my mistaken.... when I commit this fix to dev branch, I forgot to commit it to v1.1 release branch, and caused current github v1.1 release not include it.... v1.2 release is under testing, so this changes will be publish in v1.2 release, sorry for the delay. @yf13

yf13 commented 11 months ago

That is fine, just sent a PR.