search

kendzi / kendzi3d

3D plugin for JOSM
57 stars 19 forks source link

Support tunnel=* #82

Open natrius opened 6 years ago

natrius commented 6 years ago

https://wiki.openstreetmap.org/wiki/Key:tunnel Accepted proposal: https://wiki.openstreetmap.org/wiki/Proposed_features/building_passage

Tunnels do not show up at all, tagged with tunnel=yes An example: https://www.openstreetmap.org/way/24057112#map=15/47.5715/13.1670 As no mountains are rendered (i guess thats a though one), it should still only show the tube itself.

tunnel=building_passage also does not show up an example: https://www.openstreetmap.org/way/229117796

There is already maxheight= and maxwidth= suggested, but that is in my opinion for normal tunnels, maybe too for the rest. So, support tunnel= with default vaules for tunnels(semicircle shape) and building_passage(rectangular shape). For additional clarifications for 3d would be a height= a width* for a and later there could be additional to https://wiki.openstreetmap.org/wiki/DE:3D-building/Durchfahrt

As i was talking to the taggin-mailinglist, there does not seems to a "official" 3d-mailinglist or something like that and the forum itself, well, seems a bit abandoned or forgotten. And i don't know if other renderers do render it, but i don't think that should matter.

kendzi commented 6 years ago

As kendzi3d don't show ground heights I never focus on regular tunnels. You are right that they could be rendered temporary as some kind of tube on ground. If you would like you could implement something like that. Unfortunately currently I don't have time to do it my self.

As I known only "offical" place for 3d related talk is that forum. But as you noticed it is not to popular. Never less pleas feel free to write there from time to time.

https://forum.openstreetmap.org/viewforum.php?id=42

natrius commented 6 years ago

Temporary? Even when there are mountains, the tube needs to be rendered imho. Texture and so on. Unfortunately i can not program (starting to learn) or build 3d-models. :/ And, i will write in the forum, as my project would be to tag a castle and i will find some challanges. I am planning to make a post with explanation in the forum about it.

For the castle, the entrance is usally a tunnel=building_passage https://wiki.openstreetmap.org/wiki/Key:tunnel#tunnel.3Dbuilding_passage

For now, i will tag the entrance as correct as possible(Tunnel=*, width=*, height=*) and for the renderer i will temporary tag it with building:part=* as it can be removed when the tunnel=* will be rendered.