Update to JOSM 15007 - Githubissues

kendzi / kendzi3d

3D plugin for JOSM

57 stars 19 forks source link

Update to JOSM 15007 #93

Closed don-vip closed 5 years ago

don-vip commented 5 years ago

I removed deprecated API Utils.setObjectsAccessible in JOSM 15007.

The plugin uses it and it must now call ReflectionUtils.setObjectsAccessible added in JOSM 14977

don-vip commented 5 years ago

Can you please update the plugin? It makes our integration test fail.

don-vip commented 5 years ago

Hello, as you know, we require that plugins listed on https://josm.openstreetmap.de/wiki/PluginsSource are reactive when dealing with updates. Usually for low-quality plugins that are not being maintained we simply remove them when the author don't answer. However this plugin is a great piece of software, we could directly deal with updates if it was transferred to the @JOSM organization. What do you think?

don-vip commented 5 years ago

Up? Without any answer that leaves us to two choices:

remove plugin from https://josm.openstreetmap.de/wiki/PluginsSource
fork the project

Ideally I would not want to go there, but we can't keep an incompatible plugin in the default list.

kendzi commented 5 years ago

Sorry, I was on holiday. I will manage it tomorrow

kendzi commented 5 years ago

Why everything happen to break when you are out ;)

don-vip commented 5 years ago

OK thanks a lot!

kendzi commented 5 years ago

fixed and released.

don-vip commented 5 years ago

Thanks! I don't know if it's related but now we have another error: https://github.com/kendzi/Simple3dBuildingsPreset/issues/3

kendzi commented 5 years ago

I saw it and fixed just now.